Repository navigation
livekit-protocol: the thread schema - #1530
Conversation
…VERSION, Status::from_task_state)
Changeset ✓This PR includes a changeset covering all affected packages:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| livekit-protocol: patch | |||
There was a problem hiding this comment.
🟡 Dependent crate bumps missing from changeset
When livekit-protocol changes, this changeset omits its dependent crates. The changeset check requires their bumps and fails the PR.
Learn more
The changeset check computes the transitive closure of knope-managed packages depending on each changed crate in detect. Multiple managed workspace crates depend on livekit-protocol, including livekit-api, livekit-token, livekit, livekit-ffi, and livekit-uniffi. Listing only the protocol crate leaves these required bumps missing, and the check exits with failure.
Example: A change to lib.rs affects livekit-api through its workspace dependency. The check requires both crates, but finds only livekit-protocol: patch in this changeset.
Recommended fix: Run the changeset detection script with cargo available and add every reported missing knope-managed crate to the front matter with the appropriate bump.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
might need to add livekit-api to this changeset
3 participants
No description provided.